cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...
Date Sun, 10 Apr 2016 21:21:39 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1262#issuecomment-208076663
  
    I agree with you.
    We did not use this solution at first because of this:
    ```
    protected CitrixResourceBase citrixResourceBase = new CitrixResourceBase() {
      @Override
            protected String getPatchFilePath() {
                return null;
            }
        };
    ```
    
    Probably I was trying to be too perfectionist; I did not like that. Anyways, I hope we
bump Mockito version soon, so I can fix that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message