cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Fri, 08 Apr 2016 20:32:08 GMT
Github user jburwell commented on a diff in the pull request:
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/
    @@ -279,7 +284,52 @@ public boolean deleteSnapshot(Long snapshotId) {
         public boolean revertSnapshot(SnapshotInfo snapshot) {
    -        throw new CloudRuntimeException("revert Snapshot is not supported");
    +        if (canHandle(snapshot,SnapshotOperation.REVERT) == StrategyPriority.CANT_HANDLE)
    +            throw new UnsupportedOperationException("Reverting not supported. Create
a template or volume based on the snapshot instead.");
    --- End diff --
    ``UnsupportedOperationException`` means that a method implementation is not supported
on a class.  It seems that ``CloudRuntimeException`` would be a more appropriate exception
to throw under these circumstances.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message