cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Fri, 08 Apr 2016 20:16:25 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r59082995
  
    --- Diff: engine/storage/integration-test/test/org/apache/cloudstack/storage/test/FakePrimaryDataStoreDriver.java
---
    @@ -44,7 +45,7 @@
         boolean snapshotResult = true;
     
         @Override
    -    public ChapInfo getChapInfo(VolumeInfo volumeInfo) {
    +    public ChapInfo getChapInfo(DataObject dataObject) {
    --- End diff --
    
    This appears to be the default implementation from the IDE.  I realize that it predates
this patch, but should method do more?  If not, can we strike the IDE generated comment to
avoid future confusion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message