cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Fri, 08 Apr 2016 19:26:43 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r59076866
  
    --- Diff: core/src/com/cloud/agent/api/StartupRoutingCommand.java ---
    @@ -35,7 +35,7 @@
         long memory;
         long dom0MinMemory;
         boolean poolSync;
    -
    +    private boolean _supportsClonedVolumes;
    --- End diff --
    
    what about starting to use variables without "_"?
    I know ACS is full of variables starting with "_", but I believe we should start going
toward a better pattern.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message