cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Fri, 08 Apr 2016 18:50:31 GMT
Github user jburwell commented on the pull request:

    https://github.com/apache/cloudstack/pull/1403#issuecomment-207554051
  
    @mike-tutkowski @swill I don't think a formal guideline has been set, but we have been
pushing toward adopting more idiomatic Java naming conventions.  The use of ``_``, ``m_``,
and ``s_`` prefixes for class members is not idiomatic.  Generally, Java instance members
are camel case and static members are all uppercase.  It would also be nice to adopt the more
stand naming of ``LOGGER`` or ``LOG`` rather than ``s_logger``.  If it is not too much trouble,
I would encourage you to remove these prefixes.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message