cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Date Fri, 08 Apr 2016 18:12:50 GMT
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1403#issuecomment-207542455
  
    I have not seen a style guide, but I have not looked.  I have just seen a bunch of PRs
recently and there seems to be a consistent work to remove the `_`s in the code, so I figured
I would mention it.  To me, this is not a reason not to merge the code, but I agree it would
be good to know what the style should be so I can start enforcing it so we can start working
towards consistent styling.
    
    I am not requiring the LGTM code reviews to come from committers.  If you are active on
on Github and are adding value to the project by reviewing code, I am willing to work with
that.  Because I am not being strict about who is reviewing the code, I am also enforcing
at least 2 people review the code so I get more eyes on ever PR.
    
    As for the squash.  It may make sense to have some history, but there are a lot of commits
in there that are entirely useless outside the greater context of this PR.  To me, the final
version of the code merged trumps all.  If it is squashed then we can more easily evaluate
the changes associated with this commit later.  If you think there are some points in the
history of this feature that make sense to be called out as important, you can squash into
3 or 4 commits, but 43 commits for a single PR is crazy and will add more confusion than clarity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message