cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix concurrency issue on virtual router
Date Thu, 07 Apr 2016 19:08:56 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1465#discussion_r58927653
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
    @@ -292,6 +292,9 @@ public ExecutionResult executeInVR(final String routerIp, final String
script, f
             if (details == null) {
                 details = parser.getLines();
             }
    +
    +        s_logger.debug("Executing script in VR " + script);
    --- End diff --
    
    Please wrap in a ``if (s_logger.isDebugEnabled())`` block to avoid unnecessary string
concatenation when not logging at ``DEBUG`` level.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message