cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] vmware: improve support for disks
Date Thu, 07 Apr 2016 16:57:05 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1365#discussion_r58906447
  
    --- Diff: utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java
---
    @@ -39,4 +38,11 @@ public void setDiskDeviceBusName(String diskDeviceBusName) {
         public void setDiskChain(String[] diskChain) {
             this.diskChain = diskChain;
         }
    +
    +    public String getControllerFromDeviceBusName() {
    +        if (StringUtils.isEmpty(diskDeviceBusName) || !diskDeviceBusName.contains(":"))
{
    +            return null;
    --- End diff --
    
    In either case, we'll need to do a comparison to check if the string is null or empty.
Returning an empty string might cover up potential functional issues, while NPEs are bad but
can expose the issue without hiding it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message