cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Date Thu, 07 Apr 2016 16:30:29 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1441#issuecomment-206981924
  
    @swill, all of my enquiries here were answered. My only complaint was about the method
name "canHandle"; it misled me during my first and second look at this PR.I would prefer something
like "getStorageStrategyPriority".
    
    The code looks good to me though. LGTM ;)
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message