cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Remove classes with no references
Date Thu, 07 Apr 2016 16:22:42 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1453#issuecomment-206979289
  
    @DaanHoogland, @GabrielBrascher, 
    The merge errors are occurring because the PR has merge conflicts.
    A rebase should solve that.
    
    @DaanHoogland, are you going to merge this PR?
    It only has 1 LGTM and no functional tests executed for it.
    Even though I think that when removing unused code (code without any reference at all),
we do not need functional tests (a complete build and unit + integration tests are enough),
that is how it has been done so far. So, I am just asking to avoid any future complications.
@swill, what do you think here?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message