cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...
Date Wed, 06 Apr 2016 21:45:35 GMT
Github user DaanHoogland commented on a diff in the pull request:
    --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/ ---
    @@ -77,7 +80,18 @@ public Long getServiceOfferingId() {
         public Map<String, String> getDetails() {
    -        return details;
    +        Map<String, String> customparameterMap = new HashMap<String, String>();
    +        if (details != null && details.size() != 0) {
    +            Collection parameterCollection = details.values();
    +            Iterator iter = parameterCollection.iterator();
    +            while (iter.hasNext()) {
    +                HashMap<String, String> value = (HashMap<String, String>);
    --- End diff --
    the findbugs issue is here, a string is returned as a HashMap<String, String>. The
fact that this works is very ugly. It means that details is really a Map<String,Map<String,String>>.
If we want to both revert the issue and solve the findsbugs issue, the solution might be something
like writing a parser and parse the string into a map. Not sure  though

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message