cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] vmware: improve support for disks
Date Wed, 06 Apr 2016 21:26:00 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1365#discussion_r58784849
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
    @@ -4729,6 +4729,17 @@ private VirtualMachineGuestOsIdentifier translateGuestOsIdentifier(String
cpuArc
             return VirtualMachineGuestOsIdentifier.OTHER_GUEST;
         }
     
    +    private String translateGuestOsIdentifierEx(String cpuArchitecture, String guestOs,
String cloudGuestOs) {
    +        if (cloudGuestOs != null) {
    +            GuestOsDescriptorType guestOsId = GuestOsDescriptorType.fromValue(cloudGuestOs);
    +            if (guestOsId != null) {
    +                s_logger.debug("Found guest OS mapping name for guest os: " + guestOs);
    --- End diff --
    
    @rafaelweingartner the issue is the string concatenation that is performed before the
method is invoked.  It is best practice to wrap all debug and trace log calls in ``isDebugEnabled``
or ``isTraceEnabled`` to avoid the pressure on the constant pool and garbage collector from
such string concatenation across the codebase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message