cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <>
Subject [GitHub] cloudstack pull request: [4.7] vmware: improve support for disks
Date Wed, 06 Apr 2016 20:42:30 GMT
Github user jburwell commented on a diff in the pull request:
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/
    @@ -4729,6 +4729,17 @@ private VirtualMachineGuestOsIdentifier translateGuestOsIdentifier(String
             return VirtualMachineGuestOsIdentifier.OTHER_GUEST;
    +    private String translateGuestOsIdentifierEx(String cpuArchitecture, String guestOs,
String cloudGuestOs) {
    +        if (cloudGuestOs != null) {
    --- End diff --
    agreed with @rafaelweingartner -- short circuiting out of the method greatly reduces complexity
by reducing nesting.
    Also, it seems like the check should be ``Strings.isBlankorNull`` to check for empty and,
as well as, null values.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message