cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.5] vmware: improve support for disk co...
Date Wed, 06 Apr 2016 15:23:33 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1366#issuecomment-206425673
  
    
    Do you mean that the need for 2LGTMs was voted after this PR was open? It seems that it
was a direct commit. Why did you not use the merge tool? 
    
    Is it just a guideline? I have seen much less complicated PRs being reverted because they
did not have those 2LGTMS. 
    
    Could you refer the outstanding PR here too, for tracking purpose?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message