cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...
Date Mon, 04 Apr 2016 20:29:50 GMT
Github user rafaelweingartner commented on a diff in the pull request:
    --- Diff: utils/src/test/java/com/cloud/utils/ssh/ ---
    @@ -0,0 +1,131 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +import org.junit.Assert;
    +import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.mockito.Mockito;
    +import org.mockito.runners.MockitoJUnitRunner;
    +import com.trilead.ssh2.ChannelCondition;
    +import com.trilead.ssh2.Session;
    +public class SshHelperTest {
    +    // throwSshExceptionIfConditionsTimeout tests
    +    @Test(expected = SshException.class)
    +    public void throwSshExceptionIfConditionsTimeoutTestTimeout() throws SshException
    +        SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.TIMEOUT);
    +    }
    +    @Test
    +    public void throwSshExceptionIfConditionsTimeoutTestClosed() throws SshException
    --- End diff --
    Ok, got it.
    thanks for the explanation.
    Maybe a change into those test methods name? When I read their name it feels that they
should throw an exception.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message