cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Date Mon, 04 Apr 2016 13:33:24 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1444#discussion_r58375427
  
    --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
    @@ -484,6 +489,10 @@ public DomainBlockStats answer(final InvocationOnMock invocation)
throws Throwab
             // IO traffic as generated by the logic above, must be greater than zero
             Assert.assertTrue(vmStat.getDiskReadKBs() > 0);
             Assert.assertTrue(vmStat.getDiskWriteKBs() > 0);
    +        // Memory limit of VM must be greater than zero
    --- End diff --
    
    I have read and given some time to think about this test. It is very big and complicated,
but those are other issues that are due to the method itself that is being tested. 
    
    About the test coditional, I believe that the “>=” is right. Because if you are
checking the freeMemory, that method can return zero (0) in cases that you are using all of
the memory that is being allocated to the VM. I think that the comment in the test case is
misleading us.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message