cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...
Date Fri, 01 Apr 2016 22:15:27 GMT
Github user cristofolini commented on the pull request:

    https://github.com/apache/cloudstack/pull/1458#issuecomment-204588967
  
    Shouldn't the path shown in line 55 of your config file be OS-independent?
    I'd also suggest fixing the typo in the file name. At least I believe it was meant to
be Barem**e**tal_AdvZone_Vmware.cfg instead of `Baremtal_AdvZone_Vmware.cfg`.
    If you decide to fix these things, it would be nice if you squashed your commits into
a single one, since they're all implementing the same feature. :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message