Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1D2B19EC1 for ; Tue, 29 Mar 2016 10:57:02 +0000 (UTC) Received: (qmail 70215 invoked by uid 500); 29 Mar 2016 10:57:02 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 70151 invoked by uid 500); 29 Mar 2016 10:57:02 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 70139 invoked by uid 99); 29 Mar 2016 10:57:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Mar 2016 10:57:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6D8DCCEBCA for ; Tue, 29 Mar 2016 10:57:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.109 X-Spam-Level: ** X-Spam-Status: No, score=2.109 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIM_INVALID=0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=persistentsystems.onmicrosoft.com Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5oT9r28rU8a9 for ; Tue, 29 Mar 2016 10:56:59 +0000 (UTC) Received: from HJ-SMTP-OUT.persistent.co.in (hjoutgoing.persistent.co.in [103.6.33.101]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id A2CC75FB7A for ; Tue, 29 Mar 2016 10:56:58 +0000 (UTC) X-AuditID: 0a2d0811-f79456d000000ebb-66-56fa5f714599 Received: from mail.persistent.co.in (Unknown_Domain [10.44.252.65]) (using TLS with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by HJ-SMTP-OUT.persistent.co.in (HJ-SMTP-OUT @ Persistent Systems Ltd.) with SMTP id 3F.DF.03771.17F5AF65; Tue, 29 Mar 2016 16:26:49 +0530 (IST) Received: from IND01-MA1-obe.outbound.protection.outlook.com (10.45.0.30) by ht.persistent.co.in (10.44.252.65) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 29 Mar 2016 16:26:45 +0530 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=persistentsystems.onmicrosoft.com; s=selector1-accelerite-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oGxO5NLGry2vWQaURdZrHf+ULCFFLqk1MxQsP3lst1E=; b=Kc5eqOm/jQ+9A5OIb7rxvnsPEfXvRCjF14y94VGQ5WBr7I5s7f8+M+AGdWtPVHdwx8W+fpxBO3/exTdHkwhnDnCAvsh9gRAiJoCDcCC6XhhFcCDkVXAv142HIJJ142sxQD/vx4tAqYaNKCTs3W0sKiHNvlcmZVBbORHYfQueLC4= Received: from MAXPR01MB0186.INDPRD01.PROD.OUTLOOK.COM (10.164.149.140) by MAXPR01MB0186.INDPRD01.PROD.OUTLOOK.COM (10.164.149.140) with Microsoft SMTP Server (TLS) id 15.1.447.15; Tue, 29 Mar 2016 10:56:43 +0000 Received: from MAXPR01MB0186.INDPRD01.PROD.OUTLOOK.COM ([10.164.149.140]) by MAXPR01MB0186.INDPRD01.PROD.OUTLOOK.COM ([10.164.149.140]) with mapi id 15.01.0447.023; Tue, 29 Mar 2016 10:56:42 +0000 From: Koushik Das To: "dev@cloudstack.apache.org" Subject: Re: Hard coded test data Thread-Topic: Hard coded test data Thread-Index: AdGJl5XJlYSGESI0TUerM0y83LQgeAAEfChC Date: Tue, 29 Mar 2016 10:56:42 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: cloudstack.apache.org; dkim=none (message not signed) header.d=none;cloudstack.apache.org; dmarc=none action=none header.from=accelerite.com; x-originating-ip: [25.164.147.4] x-ms-office365-filtering-correlation-id: 33c1b3ef-90de-4f0d-0092-08d357c0d054 x-microsoft-exchange-diagnostics: 1;MAXPR01MB0186;5:Fn/rTRLBISJtMcsJ1kxYowZEravwsKb00QLO+9McfGBOmyj5qsPt2FcTU1RlnskewHEQQ5YDQiF8HWozTds767/dNSuuSNqItzbYScyQlijAznRhOrHt9TjESp6DZKiep9oVKtb3d5KXNh2AB3uh7g==;24:A3UYtXfGCjUlkeMtRZF0NhPuwfqVluWRu0cu52fMsEBF6ytsJz/QUORhPbYL5siGgQUmqddpPtY/QqcHMTL8biT3Gw13274o13PXNzM1/To= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MAXPR01MB0186; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:MAXPR01MB0186;BCL:0;PCL:0;RULEID:;SRVR:MAXPR01MB0186; x-forefront-prvs: 0896BFCE6C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(252514010)(38564003)(377454003)(40134004)(5002640100001)(19627595001)(81166005)(19627405001)(2351001)(189998001)(92566002)(6116002)(5003600100002)(18206015028)(122556002)(5008740100001)(19580395003)(19580405001)(450100001)(10400500002)(77096005)(19625215002)(33656002)(1096002)(3280700002)(1220700001)(17760045003)(16236675004)(586003)(2906002)(102836003)(76176999)(3846002)(3480700003)(50986999)(54356999)(86362001)(3660700001)(2501003)(110136002)(66066001)(2950100001)(107886002)(2900100001)(5004730100002);DIR:OUT;SFP:1101;SCL:1;SRVR:MAXPR01MB0186;H:MAXPR01MB0186.INDPRD01.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: multipart/alternative; boundary="_000_MAXPR01MB01869C49ED70EA55713C613C82870MAXPR01MB0186INDP_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2016 10:56:42.6437 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 1f4beacd-b7aa-49b2-aaa1-b8525cb257e0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAXPR01MB0186 X-OriginatorOrg: accelerite.com X-Brightmail-Tracker: H4sIAAAAAAAAA3WTfUgTcRjH+e1u5zlcnNPyYQmtiyKsTZdajpwoVFQoGppBb3Zthx7O29pm VhBYUqaI9GbYrMzelmUJZhE4K2Yv9oIKWdkwDcpUapVEFCazu92CILo/js99n+/z8H3ufkdi ql5CTXK8k7XzjIUmFLhi8VSGdkfBZH5CQ3Nyiu8dkY5W36mokuWgjeUoleF5q5Nxshoz6zAZ 6QyTibWwdk4QMtlCxqJZwTlMFoYrYe20hjMb6SRaY7MwJraE5Z1GmrHZWN5Mpyk0/1ypgo3j NSxvspo5vtBIr8nN1qakJBu0ejptwTx94nKFcN/2RV704ftp3HZTv6vl+TmiHNXEVaNwEqgk CIx0YxLPgr6hVqIaKUgV1S6Dtp5HcrGgoroQnBlPEAs41YBB5VBPyDWAoLX3aOihG0H7MTch thCUDo4fGA5yNLUcpmqvyUSOouZCv6tKJuk0/BrpkEu8BJ5cbg4yTs2HgYsfg71KajN4qwcJ KYbA7p+4yOHUFvBN3A/qSMj940lLcCZGxYDvfaNM2oeCC57e0G4zYfxdQC4GRVQzgsdN30Mm DbQ33ULViBQ4C178LBY9QHlkcPtpgJA8q6CrtgJJXAz+Kx1hEsfBofsumdTgRjDiPhgqxMLw reu4VLggh2f+IUJaXw37PM24xLEwNtgpP4wWuv5KLrEVavxVclfwDUTC45PvcUnXwUDdcULi RXCp6SMmsRbqA178b/0sCruCYlev1eZm5eVos9fn6Wys3cE5nMKB0pmsOo5vQ+Kp1ZKRt1HN 3XgvokhERyi7MibzVXJmp2N3iRcBidHRSn6rICnNzO49rN1aYC+1sA4vyhS+0xFMPdNk5cWR BfpEg8GQsGxpYuJSvf4/Mh2jnFBP5KuoQuFPKGZZIdGfcTIyXF2O6o4a2/tepnmixvbOGY2p dMX70wdTRgsexhvDzR3RUSsj6DTPs7JM4t7wTlQ5I3pDTu70g5pc37AVq02/2r94/43pBZ3p 677lpbZ8HRt4U38kf2T7YGl3UW/A/6ly4oWx++5hg6/POPb5XtnKU11lJyLcmi+NsaUb3r56 PdvdeX7TEhp3FDH6OMzuYH4Dg8MnMuIDAAA= --_000_MAXPR01MB01869C49ED70EA55713C613C82870MAXPR01MB0186INDP_ Content-Type: text/plain; charset="iso-8859-1" content-transfer-encoding: quoted-printable Please file tracking bugs for all such issues ________________________________ From: Sanjeev Neelarapu Sent: Tuesday, March 29, 2016 2:29 PM To: dev@cloudstack.apache.org Subject: Hard coded test data Hi, Some of the tests have hard coded test data inside tests and due to this som= e of the tests are failing in CI runs. E.g: Test_privategw_acl.py has lot of hard coded test data like vlans, static rou= tes and private gateway configuration. Unless we have these configured in t= est environment, tests would never pass. It is good practice to move the test data to test_data.py file instead of ha= rdcoding it. I request the owner of this test suite file to fix it and make it more gener= ic. Best Regards, Sanjeev N Chief Product Engineer, Accelerite Off: +91 40 6722 9368 | EMail: sanjeev.neelarapu@accelerite.com [cid:image001.png@01D18361.DE542D60] DISCLAIMER =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D This e-mail may contain privileged= and confidential information which is the property of Accelerite, a Persist= ent Systems business. It is intended only for the use of the individual or e= ntity to which it is addressed. If you are not the intended recipient, you a= re not authorized to read, retain, copy, print, distribute or use this messa= ge. If you have received this communication in error, please notify the send= er and delete all copies of this message. Accelerite, a Persistent Systems b= usiness does not accept any liability for virus infected mails. DISCLAIMER =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D This e-mail may contain privileged and confidential information which is the= property of Accelerite, a Persistent Systems business. It is intended only= for the use of the individual or entity to which it is addressed. If you ar= e not the intended recipient, you are not authorized to read, retain, copy,= print, distribute or use this message. If you have received this communicat= ion in error, please notify the sender and delete all copies of this message= . Accelerite, a Persistent Systems business does not accept any liability fo= r virus infected mails. --_000_MAXPR01MB01869C49ED70EA55713C613C82870MAXPR01MB0186INDP_--