Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: ProjectMoon <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1450-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1450-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable
 static NA...
Content-Type: text/plain
Message-Id: <20160329095158.10636DFDE0@git1-us-west.apache.org>
Date: Tue, 29 Mar 2016 09:51:58 +0000 (UTC)

Github user ProjectMoon commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1450#discussion_r57697669
  
    --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
    @@ -778,10 +778,11 @@ public int compare(final PublicIpAddress o1, final PublicIpAddress o2) {
     
                     final boolean add = ipAddr.getState() == IpAddress.State.Releasing ? false : true;
                     boolean sourceNat = ipAddr.isSourceNat();
    -                /* enable sourceNAT for the first ip of the public interface */
    -                if (firstIP) {
    -                    sourceNat = true;
    +                /* enable sourceNAT for the first ip of the public interface as long as it's source nat. */
    +                if (firstIP && !sourceNat) {
    --- End diff --
    
    How do I trigger this case using the CS API? Is it by adding multiple NICs to the virtual router?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---