Return-Path: 
 <dev-return-90815-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3976319CEC
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Thu, 24 Mar 2016 18:03:12 +0000 (UTC)
Received: (qmail 36597 invoked by uid 500); 24 Mar 2016 18:03:11 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 36546 invoked by uid 500); 24 Mar 2016 18:03:11 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 36535 invoked by uid 99); 24 Mar 2016 18:03:11 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2016 18:03:11 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 05656DFBD6; Thu, 24 Mar 2016 18:03:11 +0000 (UTC)
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1371-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1371-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: OSPF: adding dynamically routing
 capabili...
Content-Type: text/plain
Message-Id: <20160324180311.05656DFBD6@git1-us-west.apache.org>
Date: Thu, 24 Mar 2016 18:03:11 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r57360768
  
    --- Diff: api/src/com/cloud/network/vpc/VpcProvisioningService.java ---
    @@ -26,13 +25,11 @@
     
         public VpcOffering getVpcOffering(long vpcOfferingId);
     
    -    public VpcOffering createVpcOffering(String name, String displayText, List<String> supportedServices,
    -                                         Map<String, List<String>> serviceProviders,
    -                                         Map serviceCapabilitystList,
    -                                         Long serviceOfferingId);
    +    public VpcOffering createVpcOffering(String name, String displayText, List<String> supportedServices, Map<String, List<String>> serviceProviders, Map serviceCapabilitystList,
    +            Long serviceOfferingId);
     
    -    Pair<List<? extends VpcOffering>,Integer> listVpcOfferings(Long id, String name, String displayText, List<String> supportedServicesStr, Boolean isDefault, String keyword,
    -        String state, Long startIndex, Long pageSizeVal);
    +    Pair<List<? extends VpcOffering>, Integer> listVpcOfferings(Long id, String name, String displayText, List<String> supportedServicesStr, Boolean isDefault, String keyword,
    +            String state, Long startIndex, Long pageSizeVal);
    --- End diff --
    
    This appears to be a spurious formatting change that violates our coding standards.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---