Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: andrijapanic <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1230-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1230-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots
 on RB...
Content-Type: text/plain
Message-Id: <20160323134643.667A3DFAFF@git1-us-west.apache.org>
Date: Wed, 23 Mar 2016 13:46:43 +0000 (UTC)

Github user andrijapanic commented on the pull request:

    https://github.com/apache/cloudstack/pull/1230#issuecomment-200350271
  
    I believe this is the reason Dmytro edit it, since it handles KVM stuff
    also...
    
    On 23 March 2016 at 14:40, Simon Weller <notifications@github.com> wrote:
    
    > @DaanHoogland <https://github.com/DaanHoogland>
    >
    > So I've been digging into this a bit. I could be very wrong here, but it
    > seems that XenserverSnapshotStrategy is a very inaccurate description of
    > what this class is actually doing. It seems to be very general and based on
    > some investigation being used for KVM as well. This might be an old
    > artifact of the original feature being Xen specific, until others
    > re-purposed it for other hypervisors.
    >
    > Mike @mike-tutkowski <https://github.com/mike-tutkowski> mentioned
    > something to this effect very recently in this PR: #1441
    > <https://github.com/apache/cloudstack/pull/1441>
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/1230#issuecomment-200347989>
    >
    
    
    -- 
    
    Andrija Panić


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---