Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 90F9A18DE8 for ; Tue, 8 Mar 2016 15:40:02 +0000 (UTC) Received: (qmail 62905 invoked by uid 500); 8 Mar 2016 15:39:57 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 62847 invoked by uid 500); 8 Mar 2016 15:39:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 62835 invoked by uid 99); 8 Mar 2016 15:39:56 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Mar 2016 15:39:56 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D664CDFA6C; Tue, 8 Mar 2016 15:39:56 +0000 (UTC) From: ustcweizhou To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x Content-Type: text/plain Message-Id: <20160308153956.D664CDFA6C@git1-us-west.apache.org> Date: Tue, 8 Mar 2016 15:39:56 +0000 (UTC) Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1430#issuecomment-193827846 @kiwiflyer code LGTM. can you (1) squash the commits, (2) add a space before s_logger.info ? We use 4 space indentation in java. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---