Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: swill <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1427-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1427-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: findbugs: new found old instance of
 DM_DE...
Content-Type: text/plain
Message-Id: <20160302193347.86981E2F34@git1-us-west.apache.org>
Date: Wed,  2 Mar 2016 19:33:47 +0000 (UTC)

Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1427#issuecomment-191389512
  
    It looks like your IDE had a field day with this class.  So other than the reordering of imports, adding `final` to a ton of variables and removing some unneeded brackets, this is really the only change?  Right?
    
    `
    -        String dir = UUID.nameUUIDFromBytes(nfsPath.getBytes()).toString();
    +        final String dir = UUID.nameUUIDFromBytes(nfsPath.getBytes(getPreferredCharset())).toString();
    `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---