Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D28818F1C for ; Wed, 2 Mar 2016 17:55:14 +0000 (UTC) Received: (qmail 40297 invoked by uid 500); 2 Mar 2016 17:55:13 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 40243 invoked by uid 500); 2 Mar 2016 17:55:13 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 40220 invoked by uid 99); 2 Mar 2016 17:55:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Mar 2016 17:55:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 52754E05E1; Wed, 2 Mar 2016 17:55:13 +0000 (UTC) From: syed To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro... Content-Type: text/plain Message-Id: <20160302175513.52754E05E1@git1-us-west.apache.org> Date: Wed, 2 Mar 2016 17:55:13 +0000 (UTC) Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1424#discussion_r54762401 --- Diff: server/src/com/cloud/template/TemplateManagerImpl.java --- @@ -275,6 +277,8 @@ private StorageCacheManager cacheMgr; @Inject private EndPointSelector selector; + @Inject + private ImageStoreDao _imgStoreDao; --- End diff -- So all other "Dao" variables in the class have a "_" before their name. I tried to keep it that way to follow convention. I've moved my variable to the same group where the other Dao variables are defiend, it should be more consistent now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---