Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: pedro-martins <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1424-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1424-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create
 template fro...
Content-Type: text/plain
Message-Id: <20160301164149.75618DFCB8@git1-us-west.apache.org>
Date: Tue,  1 Mar 2016 16:41:49 +0000 (UTC)

Github user pedro-martins commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1424#discussion_r54595010
  
    --- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
    @@ -275,6 +277,8 @@
         private StorageCacheManager cacheMgr;
         @Inject
         private EndPointSelector selector;
    +    @Inject
    +    private ImageStoreDao _imgStoreDao;
    --- End diff --
    
    hi @syed,
    could you remove the "_" character from the variable name? the underscore is usually used in c++ programs to name private variables but it is not a convention in Java.
    Ty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---