Return-Path: 
 <dev-return-89968-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 128E918590
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Tue,  1 Mar 2016 14:51:21 +0000 (UTC)
Received: (qmail 1692 invoked by uid 500); 1 Mar 2016 14:51:20 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 1636 invoked by uid 500); 1 Mar 2016 14:51:20 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 1625 invoked by uid 99); 1 Mar 2016 14:51:20 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2016 14:51:20 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 3D555DFB8A; Tue,  1 Mar 2016 14:51:20 +0000 (UTC)
From: nvazquez <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1425-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1425-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve
 performance of r...
Content-Type: text/plain
Message-Id: <20160301145120.3D555DFB8A@git1-us-west.apache.org>
Date: Tue,  1 Mar 2016 14:51:20 +0000 (UTC)

Github user nvazquez commented on the pull request:

    https://github.com/apache/cloudstack/pull/1425#issuecomment-190753666
  
    Hi @rafaelweingartner,
    
    Sure, I changed it to a method and added javadoc to it.
    
    I added the new constructor at <code>ResourceTagJoinVO</code> to set all that fields in a single call instead of many setter methods. Which way could be better?
    
    Yes, I tested <code>template_view</code> and it retrieves data.
    
    Thanks,
    Nicolas


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---