Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: Remi Bergsma <RBergsma@schubergphilis.com>
To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org>
Subject: Re: [DISCUSS] PR testing process 
Thread-Topic: [DISCUSS] PR testing process 
Thread-Index: AdGIwBIPgEraA0Y6S0Gr/yiiBe+bEQAA8umAAADIMow=
Date: Mon, 28 Mar 2016 07:54:03 +0000
Message-ID: <0CA7CD22-A6FA-496B-A2E4-83693663F11A@schubergphilis.com>
References: 
 <MA1PR01MB01201F17578606F52A32801789860@MA1PR01MB0120.INDPRD01.PROD.OUTLOOK.COM>,<90B6A438-8D0B-4FEA-86E5-38BF75A8D9C6@persistent.co.in>
In-Reply-To: <90B6A438-8D0B-4FEA-86E5-38BF75A8D9C6@persistent.co.in>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Indeed. If a merge fails then you'll not be able to merge it to master or a=
nother release branch later on anyway so the author must rebase against the=
 base branch first. No need spending test cycles on that.=20

Most likely github already reports that PR as 'unstable' so you could also =
check for that.=20

Regards, Remi=20

Sent from my iPhone

> On 28 Mar 2016, at 09:28, Bharat Kumar <bharat.kumar@accelerite.com> wrot=
e:
>=20
> Hi Sanjeev,
>=20
> Thanks for bringing this up.
>=20
> This is happening because the PR code and the master have deviated since =
the pr has been created(assuming that PR was rebased with master at the tim=
e of creation)  and we start testing it. Ideally we should start testing as=
 soon as the pr is created but due to hardware limitation we have to queue =
the PRs for testing.
>=20
> One way of fixing this would be to merge the PR with master before testin=
g, If the merge fails we post a comment on the PR and skip testing it, unti=
l it can me merged.
>=20
> We need to make sure that all the PR we create can be merged to master wi=
thout conflicts.
>=20
> Thanks,
> Bharat.
>=20
>=20
> On 28-Mar-2016, at 12:35 PM, Sanjeev Neelarapu <sanjeev.neelarapu@acceler=
ite.com<mailto:sanjeev.neelarapu@accelerite.com>> wrote:
>=20
> Hi,
>=20
> Currently CI is picking the code from the PR branch, which may or may not=
 be rebased with latest master. This is causing test failures even though t=
hey were fixed in latest master.
> e.g.: test_vpc_site2site_vpn.
> Error Message
> local variable 'vm1' referenced before assignment.
>=20
> There were few issues with this test suite which were fixed in master. Ho=
wever, we don=92t see these changes in some of the PR branches.
>=20
> Any thoughts on how to overcome this?
>=20
>=20
> Best Regards,
> Sanjeev N
> Chief Product Engineer, Accelerite
> Off: +91 40 6722 9368 | EMail: sanjeev.neelarapu@accelerite.com<mailto:sa=
njeev.neelarapu@accelerite.com>
>=20
>=20
> DISCLAIMER =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D This e-mail may contain privile=
ged and confidential information which is the property of Accelerite, a Per=
sistent Systems business. It is intended only for the use of the individual=
 or entity to which it is addressed. If you are not the intended recipient,=
 you are not authorized to read, retain, copy, print, distribute or use thi=
s message. If you have received this communication in error, please notify =
the sender and delete all copies of this message. Accelerite, a Persistent =
Systems business does not accept any liability for virus infected mails.
>=20
>=20
>=20
>=20
> DISCLAIMER
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> This e-mail may contain privileged and confidential information which is =
the property of Accelerite, a Persistent Systems business. It is intended o=
nly for the use of the individual or entity to which it is addressed. If yo=
u are not the intended recipient, you are not authorized to read, retain, c=
opy, print, distribute or use this message. If you have received this commu=
nication in error, please notify the sender and delete all copies of this m=
essage. Accelerite, a Persistent Systems business does not accept any liabi=
lity for virus infected mails.