cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pedro-martins <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removed unused parameters and variable fr...
Date Sun, 20 Mar 2016 01:02:25 GMT
GitHub user pedro-martins opened a pull request:

    https://github.com/apache/cloudstack/pull/1447

    Removed unused parameters and variable from NetworkHelper hierarchy

    - Was removed the unused params User & Account in the com.cloud.network.router.NetworkHelper.startVirtualRouter(DomainRouterVO,
User, Account, Map<Param, Object>) and the param Long in the com.cloud.network.router.NetworkHelper.destroyRouter(long,
Account, Long)
    
    - Also, was removed the unused params User & Account from com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO,
User, Account, Map<Param, Object>, DeploymentPlan)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pedro-martins/cloudstack lrg-cs-hackday-032

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1447.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1447
    
----
commit 35bfb918828d3f69a2ae549cedce40177e9bd2aa
Author: pedro-martins <phpm13@gmail.com>
Date:   2016-03-19T22:42:35Z

    remove unused parameters and variable from NetworkHelper hierarchy

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message