cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From insom <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...
Date Tue, 29 Mar 2016 15:25:31 GMT
Github user insom commented on the pull request:

    https://github.com/apache/cloudstack/pull/1451#issuecomment-202951746
  
    @pedro-martins Thanks for the review but I don't want to make this change because (a)
it'll mix two intents into on PR - fixing the bug *and* improving the logging - and (b) it
would be *less* consistent with the rest of the CloudStack code base which, for better or
worse, largely uses string concatenation for debug logging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message