cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ProjectMoon <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...
Date Tue, 29 Mar 2016 09:51:58 GMT
Github user ProjectMoon commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1450#discussion_r57697669
  
    --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
    @@ -778,10 +778,11 @@ public int compare(final PublicIpAddress o1, final PublicIpAddress
o2) {
     
                     final boolean add = ipAddr.getState() == IpAddress.State.Releasing ?
false : true;
                     boolean sourceNat = ipAddr.isSourceNat();
    -                /* enable sourceNAT for the first ip of the public interface */
    -                if (firstIP) {
    -                    sourceNat = true;
    +                /* enable sourceNAT for the first ip of the public interface as long
as it's source nat. */
    +                if (firstIP && !sourceNat) {
    --- End diff --
    
    How do I trigger this case using the CS API? Is it by adding multiple NICs to the virtual
router?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message