cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Mon, 28 Mar 2016 13:56:33 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r57573475
  
    --- Diff: core/src/com/cloud/agent/api/storage/CopyVolumeCommand.java ---
    @@ -75,4 +76,12 @@ public boolean toSecondaryStorage() {
         public String getVmName() {
             return vmName;
         }
    +
    +    public String getNfsVersion() {
    +        return nfsVersion;
    +    }
    +
    +    public void setNfsVersion(String nfsVersion) {
    +        this.nfsVersion = nfsVersion;
    +    }
    --- End diff --
    
    This looks like a useful change to the storage API, but why is it necessary to implement
OSPF?  Seems like it should be in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message