cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...
Date Sun, 27 Mar 2016 21:53:00 GMT
Github user cristofolini commented on the pull request:

    https://github.com/apache/cloudstack/pull/1450#issuecomment-202152926
  
    @ProjectMoon According to that comment on line 781 in `CommandSetupHelper` the conditional
that follows is there to enable sourceNAT, yet you removed the command setting the sourceNat
variable to true. Is that being done somewhere else? You might want to change that comment
to clarify your change and avoid confusion in the future. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message