cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...
Date Sun, 27 Mar 2016 21:25:27 GMT
Github user cristofolini commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1451#discussion_r57535012
  
    --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
---
    @@ -180,7 +179,7 @@ private Answer applyConfig(NetworkElementCommand cmd, List<ConfigItem>
cfg) {
             boolean finalResult = false;
             for (ConfigItem configItem : cfg) {
                 long startTimestamp = System.currentTimeMillis();
    -            ExecutionResult result = applyConfigToVR(cmd.getRouterAccessIp(), configItem);
    +            ExecutionResult result = applyConfigToVR(cmd.getRouterAccessIp(), configItem,
VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT);
    --- End diff --
    
    @insom Since you're now checking the timeout's validity when calling `applyConfigToVR`
shouldn't the last parameter passed through this call be `timeout` instead of `VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message