cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix new error found in findbugs slow buil...
Date Sun, 27 Mar 2016 12:50:22 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1438#discussion_r57527860
  
    --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
    @@ -395,16 +391,9 @@ protected Answer copyFromS3ToNfs(CopyCommand cmd, DataTO srcData,
S3TO s3, DataT
                         return new CopyCmdAnswer(errMsg);
                     }
                 }
    -
                 File destFile = new File(downloadDirectory, substringAfterLast(srcData.getPath(),
S3Utils.SEPARATOR));
    -
                 S3Utils.getFile(s3, s3.getBucketName(), srcData.getPath(), destFile).waitForCompletion();
     
    -
    -            if (destFile == null) {
    --- End diff --
    
    I removed that because the new File (...) will always create an object that is referenced
by destFile; therefore, it will never be == null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message