cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <>
Subject [GitHub] cloudstack pull request: Fix new error found in findbugs slow buil...
Date Fri, 25 Mar 2016 20:16:30 GMT
Github user swill commented on a diff in the pull request:
    --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/
    @@ -395,16 +391,9 @@ protected Answer copyFromS3ToNfs(CopyCommand cmd, DataTO srcData,
S3TO s3, DataT
                         return new CopyCmdAnswer(errMsg);
                 File destFile = new File(downloadDirectory, substringAfterLast(srcData.getPath(),
                 S3Utils.getFile(s3, s3.getBucketName(), srcData.getPath(), destFile).waitForCompletion();
    -            if (destFile == null) {
    --- End diff --
    Is this because `new File(...)` will always throw an exception if the value would be `null`?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message