cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abhinandanprateek <...@git.apache.org>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Fri, 25 Mar 2016 09:05:44 GMT
Github user abhinandanprateek commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r57429458
  
    --- Diff: api/src/com/cloud/network/vpc/VpcProvisioningService.java ---
    @@ -26,13 +25,11 @@
     
         public VpcOffering getVpcOffering(long vpcOfferingId);
     
    -    public VpcOffering createVpcOffering(String name, String displayText, List<String>
supportedServices,
    -                                         Map<String, List<String>> serviceProviders,
    -                                         Map serviceCapabilitystList,
    -                                         Long serviceOfferingId);
    +    public VpcOffering createVpcOffering(String name, String displayText, List<String>
supportedServices, Map<String, List<String>> serviceProviders, Map serviceCapabilitystList,
    +            Long serviceOfferingId);
     
    -    Pair<List<? extends VpcOffering>,Integer> listVpcOfferings(Long id, String
name, String displayText, List<String> supportedServicesStr, Boolean isDefault, String
keyword,
    -        String state, Long startIndex, Long pageSizeVal);
    +    Pair<List<? extends VpcOffering>, Integer> listVpcOfferings(Long id,
String name, String displayText, List<String> supportedServicesStr, Boolean isDefault,
String keyword,
    +            String state, Long startIndex, Long pageSizeVal);
    --- End diff --
    
    @jburwell 
    Have picked up the formatter for eclipse from https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions
    Have not been fixing the style and formatting by hand but relying on the auto formatting
that conforms to apache standard as per the above wiki.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message