cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Thu, 24 Mar 2016 18:48:11 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r57368304
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/vpc/VPCQuaggaConfigUpdateCmd.java
---
    @@ -0,0 +1,204 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +
    +package org.apache.cloudstack.api.command.admin.vpc;
    +
    +import java.util.Map;
    +
    +import javax.inject.Inject;
    +
    +import org.apache.cloudstack.api.APICommand;
    +import org.apache.cloudstack.api.ApiConstants;
    +import org.apache.cloudstack.api.BaseCmd;
    +import org.apache.cloudstack.api.Parameter;
    +import org.apache.cloudstack.api.response.VPCQuaggaConfigResponse;
    +import org.apache.cloudstack.api.response.ZoneResponse;
    +import org.apache.log4j.Logger;
    +
    +import com.cloud.network.vpc.QuaggaZoneConfig;
    +import com.cloud.network.vpc.VpcProvisioningService;
    +import com.cloud.user.Account;
    +
    +@APICommand(name = "vpcQuaggaConfigUpdate", description = "Captures config informaton
for quagga", responseObject = VPCQuaggaConfigResponse.class, since = "4.8.0", requestHasSensitiveInfo
= true)
    +public class VPCQuaggaConfigUpdateCmd extends BaseCmd {
    +    public static final Logger s_logger = Logger.getLogger(VPCQuaggaConfigUpdateCmd.class.getName());
    +    private static final String s_name = "vpcquaggaconfigresponse";
    +
    +    /////////////////////////////////////////////////////
    +    //////////////// API parameters /////////////////////
    +    /////////////////////////////////////////////////////
    +
    +    @Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID, entityType = ZoneResponse.class,
required = true, description = "the ID of the Zone")
    +    private Long zoneid;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_quaggaProtocol, type = CommandType.STRING, required
= false, description = "the password used to secure inter quagga communication(default ospf)")
    +    private String quaggaProtocol;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_ospfArea, type = CommandType.STRING, required
= false, description = "Specify the OSPF Area ID")
    +    private String ospfArea;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_quaggaHelloInterval, type = CommandType.SHORT,
required = false, description = "Set number of seconds for HelloInterval timer value.(default
10)")
    +    private Short quaggaHelloInterval;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_quaggaDeadInterval, type = CommandType.SHORT,
required = false, description = "Set number of seconds for RouterDeadInterval timer value
used for Wait Timer and Inactivity Timer.(default 40)")
    +    private Short quaggaDeadInterval;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_quaggaRetransmitInterval, type = CommandType.SHORT,
required = false, description = "Set number of seconds for RxmtInterval timer value.(default
5)")
    +    private Short quaggaRetransmitInterval;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_quaggaTransitDelay, type = CommandType.SHORT,
required = false, description = "Set number of seconds for InfTransDelay value.(default 1)")
    +    private Short quaggaTransitDelay;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_quaggaAuthentication, type = CommandType.STRING,
required = false, description = "Md5 or PlainText (default MD5)")
    +    private String quaggaAuthentication;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_quaggaPassword, type = CommandType.STRING, required
= false, description = "The password used to secure inter quagga communication")
    +    private String quaggaPassword;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_ospfSuperCIDR, type = CommandType.STRING, required
= false, description = "The super zone level CIDR for ospf enabled VPCs")
    +    private String ospfSuperCIDR;
    +
    +    @Parameter(name = QuaggaZoneConfig.s_quaggaEnabled, type = CommandType.BOOLEAN, required
= false, description = "The flag to enable or disable quagga for this zone")
    +    private Boolean quaggaEnabled;
    +
    +    @Inject
    +    public VpcProvisioningService _vpcProvSvc;
    +
    +    public Long getZoneid() {
    +        return zoneid;
    +    }
    +
    +    public void setZoneid(Long zoneid) {
    +        this.zoneid = zoneid;
    +    }
    +
    +    public Long getId() {
    +        return zoneid;
    +    }
    +
    +    public String getQuaggaProtocol() {
    +        return quaggaProtocol;
    +    }
    +
    +    public void setQuaggaProtocol(String quaggaProtocol) {
    +        this.quaggaProtocol = quaggaProtocol;
    +    }
    +
    +    public String getOspfArea() {
    +        return ospfArea;
    +    }
    +
    +    public void setOspfArea(String ospfArea) {
    +        this.ospfArea = ospfArea;
    +    }
    +
    +    public Short getQuaggaHelloInterval() {
    +        return quaggaHelloInterval;
    +    }
    +
    +    public void setQuaggaHelloInterval(Short quaggaHelloInterval) {
    +        this.quaggaHelloInterval = quaggaHelloInterval;
    +    }
    +
    +    public Short getQuaggaDeadInterval() {
    +        return quaggaDeadInterval;
    +    }
    +
    +    public void setQuaggaDeadInterval(Short quaggaDeadInterval) {
    +        this.quaggaDeadInterval = quaggaDeadInterval;
    +    }
    +
    +    public Short getQuaggaRetransmitInterval() {
    +        return quaggaRetransmitInterval;
    +    }
    +
    +    public void setQuaggaRetransmitInterval(Short quaggaRetransmitInterval) {
    +        this.quaggaRetransmitInterval = quaggaRetransmitInterval;
    +    }
    +
    +    public Short getQuaggaTransitDelay() {
    +        return quaggaTransitDelay;
    +    }
    +
    +    public void setQuaggaTransitDelay(Short quaggaTransitDelay) {
    +        this.quaggaTransitDelay = quaggaTransitDelay;
    +    }
    +
    +    public String getQuaggaAuthentication() {
    +        return quaggaAuthentication;
    +    }
    +
    +    public void setQuaggaAuthentication(String quaggaAuthentication) {
    +        this.quaggaAuthentication = quaggaAuthentication;
    +    }
    +
    +    public String getQuaggaPassword() {
    +        return quaggaPassword;
    +    }
    +
    +    public void setQuaggaPassword(String quaggaPassword) {
    +        this.quaggaPassword = quaggaPassword;
    +    }
    +
    +    public String getOspfSuperCIDR() {
    +        return ospfSuperCIDR;
    +    }
    +
    +    public void setOspfSuperCIDR(String ospfSuperCIDR) {
    +        this.ospfSuperCIDR = ospfSuperCIDR;
    +    }
    +
    +    public Boolean getQuaggaEnabled() {
    +        return quaggaEnabled;
    +    }
    +
    +    public void setQuaggaEnabled(Boolean quaggaEnabled) {
    +        this.quaggaEnabled = quaggaEnabled;
    +    }
    +
    +    @Override
    +    public void execute() {
    +        s_logger.info(this.toString());
    --- End diff --
    
    Why are logging the content of this request to ``INFO``?  It seems like it should be ``DEBUG``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message