cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Date Thu, 24 Mar 2016 18:04:17 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r57360954
  
    --- Diff: api/src/com/cloud/network/vpc/VpcProvisioningService.java ---
    @@ -49,4 +46,9 @@ public VpcOffering createVpcOffering(String name, String displayText,
List<Strin
          */
         public VpcOffering updateVpcOffering(long vpcOffId, String vpcOfferingName, String
displayText, String state);
     
    +    Map<String, String> quaggaConfigUpdate(Long id, String protocol, String ospfArea,
Short helloInterval, Short deadInterval, Short retransmitInterval, Short transitDelay,
    +            String authentication, String password, String superCIDR, Boolean enabled);
    +
    +    Map<String, String> quaggaConfig(Long id);
    --- End diff --
    
    Please rename to conform to <verb><noun> method naming idiom (e.g. updateQuaggaConfig).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message