cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x
Date Thu, 24 Mar 2016 16:33:30 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1430#issuecomment-200914880
  
    Ok,
    So, this agent class is executed as a service in the operating system (OS) the OS will
call a service that calls the main method that instantiates and executes that agent right?

    
    If an exception is thrown and it is not handled properly the agent dies. If the agent
dies, ACS does not deal with it, right? 
    
    In that case, I would be inclined to accept the infinite loop when starting a connection.
I would only suggest not hiding the exception there, and logging it together with messages
at lines 239, 238 and 415.
    
    I just wonder why we need to maintain a connection like this one always open. For me,
it seems that if we only opened it when sending a command, then we could send the command,
and after that we could close the connection. Therefore, if it is not possible to open a connection
we could just lose a command. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message