cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <...@git.apache.org>
Subject [GitHub] cloudstack pull request: speedup iptables setup
Date Mon, 21 Mar 2016 22:29:24 GMT
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1449#issuecomment-199517201
  
    @kollyma, maybe just add a comment at the top to mention something like "pre-fetch the
variables so they are not done inline" or something like that and this should prompt another
build without having to create a new PR.  Since we can't close a PR without a merge, this
is probably the simplest way to handle it.  Good comments are rarely a bad thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message