cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GabrielBrascher <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes
Date Mon, 21 Mar 2016 13:19:54 GMT
Github user GabrielBrascher commented on the pull request:

    https://github.com/apache/cloudstack/pull/1448#issuecomment-199272015
  
    @DaanHoogland the lack of test in some classes indeed is a problem. However, these classes
that I removed are not being used.
    
    I used UCDetector (http://www.ucdetector.org/) as a plugin for Eclipse.  With this tool,
I discovered a lot of code without any reference (variables, methods and classes).
    
    This pull request had the goal of removing some of these classes. To ensure that I wasn't
missing anything I searched for any file that could reference some answer or API command.
As I haven't found any way of these classes being used, I removed them.
    
    Any of those API commands that I deleted are not using org.apache.cloudstack.api.APICommand
(with `@APICommand`). Therefore, those commands are not exposed in the ACS API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message