cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kishankavala <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Date Mon, 21 Mar 2016 10:49:01 GMT
Github user kishankavala commented on the pull request:

    https://github.com/apache/cloudstack/pull/780#issuecomment-199222784
  
    @swill @remibergsma @DaanHoogland PR was open since Sep 2015. Review from @swill came
after the PR was merged on Mar 17 2016. By then, there were code reviews and tests done with
3 LGTMs. I merged the PR as per the current process.  
    Unfortunately all reviewers missed the issued mentioned by @swill   
    Thanks to @rafaelweingartner https://github.com/apache/cloudstack/pull/1444 addresses
the runtime exception issues.
    Unless there are issues with PR 1444, I do not see a need to revert this merge. Can we
all please review PR 1444 and close this issue?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message