cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Date Mon, 21 Mar 2016 10:18:22 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1441#discussion_r56801490
  
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
    @@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
     
         @Override
         public boolean revertSnapshot(SnapshotInfo snapshot) {
    -        throw new CloudRuntimeException("revert Snapshot is not supported");
    +        if (canHandle(snapshot,SnapshotOperation.REVERT) == StrategyPriority.CANT_HANDLE)
{
    --- End diff --
    
    @rafaelweingartner if you consider changing a canHandle() method take care. These are
called over all types of resources and should not break contract as to not confuse any Orchestrators
in the system.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message