cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Date Thu, 17 Mar 2016 17:04:51 GMT
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/1441#issuecomment-197975991
  
    CloudStack iterates over all known snapshot strategies and asks each if it can handle
a particular situation (take, delete, revert) for a volume or volume snapshot.
    
    One with a priority higher than the others is selected.
    
    If you can't handle the particular use case, you return CANT_HANDLE.
    
    On Mar 17, 2016, at 12:49 PM, Rafael Weing?rtner <notifications@github.com<mailto:notifications@github.com>>
wrote:
    
    
    Ok @mike-tutkowski<https://github.com/mike-tutkowski>, now I believe I understand
a little bit more of the code.
    
    You are reusing a method that already exist and returns the StrategyPriority (you did
not create that method to suffice your code). I was misled by the name of the method, when
I first saw it, I thought that the method was used solely to check if it can or cannot proceed
with the snapshot when in fact it is used to do much more.
    
    I believe "getSnapshotStrategy" would be a more suitable name.
    
    Now that I understand what we have there, I am ok with that conditional as it
    is.
    
    -
    You are receiving this because you were mentioned.
    Reply to this email directly or view it on GitHub<https://github.com/apache/cloudstack/pull/1441#issuecomment-197970382>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message