cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Date Thu, 17 Mar 2016 16:02:11 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1441#issuecomment-197948544
  
    I understand that your point that some other classes can overwrite that method and may
return other elements of the enum. However, I do not see anything else in the code that used
the “canHandle” method return that uses the returned value. I mean, it is used in the
“revertSnapshot” method at line 285, but it only checks if the return is equal to “StrategyPriority.CANT_HANDLE”
and then throws an exception if it is. To me, that is the same as if the method were returning
a boolean value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message