cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Date Thu, 17 Mar 2016 15:50:18 GMT
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/1441#issuecomment-197942848
  
    The canHandle method is used by CloudStack's snapshot infrastructure to determine which
snapshot strategy to use.
    
    For example, StorageSystemSnapshotStrategy returns either StrategyPriority.HIGHEST or
StrategyPriority.CANT_HANDLE whereas XenserverSnapshotStrategy returns StrategyPriority.DEFAULT
or StrategyPriority.CANT_HANDLE.
    
    That being the case, there are at least three options in play (and other people can write
custom snapshot strategies that they don't even check into the CloudStack repo, so we can't
easily just change the interface where canHandle is declared).
    
    As for this sentence:
    
    “I see returning true as your revert was successful and returning false as it failed
(but it was OK for you to ask us to revert because canHandle properly told you that you could
do so)”
    
    That was in regards to the revertSnapshot method. It sounds like you agree with the exception
being thrown there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message