cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9297: delete snapshot without ...
Date Thu, 17 Mar 2016 15:21:33 GMT
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/1441#issuecomment-197929660
  
    Hi @rafaelweingartner Thanks for the comments.
    
    Just wanted to point out that if the revertSnapshot method is invoked, then that is actually
a failure of the canHandle method to inform the calling code to not call the revertSnapshot
method, so that's why the decision was made to throw an exception.
    
    I see returning true as your revert was successful and returning false as it failed (but
it was OK for you to ask us to revert because canHandle properly told you that you could do
so).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message