cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Date Thu, 17 Mar 2016 14:14:29 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/780#discussion_r56509815
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
    @@ -4879,10 +4889,16 @@ private VirtualMachineGuestOsIdentifier translateGuestOsIdentifier(String
cpuArc
                             } else if (objProp.getName().contains(instanceNameCustomField))
{
    --- End diff --
    
    Here it is the same as in CitrixResourceBase.java. I know you just followed the way the
code was written here before, but this “if/else/if/else……” structure is too big; I
believe to introduce some changes like this here; it would be much appreciated a refactoring.
I do not mean a huge refactoring, only the extraction of this if/else structure to a method
and then using some other clever way to do these checks and to retrieve the values. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message