cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Date Thu, 17 Mar 2016 14:05:25 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/780#discussion_r56508389
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
    @@ -3026,11 +3031,16 @@ public VmStatsEntry getVmStat(final Connect conn, final String
vmName) throws Li
             try {
                 dm = getDomain(conn, vmName);
                 final DomainInfo info = dm.getInfo();
    +            final MemoryStatistic[] mems = dm.memoryStats(NUMMEMSTATS);      //number
of memory statistics required.
     
                 final VmStatsEntry stats = new VmStatsEntry();
    +
                 stats.setNumCPUs(info.nrVirtCpu);
                 stats.setEntityType("vm");
     
    +            stats.setMemoryKBs(info.maxMem);
    +            stats.setTargetMemoryKBs(info.memory);
    +            stats.setIntFreeMemoryKBs((double) mems[0].getValue());
    --- End diff --
    
    the same problem pointed out by @swill at line 3128, may happen here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message