cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...
Date Sat, 12 Mar 2016 00:59:26 GMT
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1437#issuecomment-195620065
  
    @GabrielBrascher based on what tests? It was only compiled.
    
    I'm with @eriweb here, this should not go in without testing. Ask on the ML if someone
with HyperV can confirm it still works and run at least `vm_life_cycle` integration tests.
    
    @rafaelweingartner "There are things that do not need to be tested"? C'mon please.
    
    To be clear: -1:-1: on this until we have done integration testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message